Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Croston Forecaster needs extra argument "fitted" [BUG] #1104

Closed
JensvandeZande opened this issue Jul 30, 2022 · 3 comments
Closed

Croston Forecaster needs extra argument "fitted" [BUG] #1104

JensvandeZande opened this issue Jul 30, 2022 · 3 comments
Labels
question Further information is requested

Comments

@JensvandeZande
Copy link

Describe the bug
When trying to fit a Croston Forecaster it returns a TypeError: not enough arguments: expected 4, got 3

To Reproduce

from darts.datasets import AirPassengersDataset
from darts.models import Croston

passengers = AirPassengersDataset()
y = passengers.load()

train = y[:-12]
val = y[-12:]

model = Croston()
model.fit(train)

Expected behavior
A fitted model without errors

System (please complete the following information):

  • Python version: [3.19.13]
  • darts version [0.20.0]
@JensvandeZande JensvandeZande added bug Something isn't working triage Issue waiting for triaging labels Jul 30, 2022
@hrzn
Copy link
Contributor

hrzn commented Jul 30, 2022

I just tried and for me it works:
image

Could you try again in a blank virtual environment?

@hrzn hrzn added question Further information is requested and removed bug Something isn't working triage Issue waiting for triaging labels Jul 30, 2022
@dennisbader
Copy link
Collaborator

dennisbader commented Aug 1, 2022

@JensvandeZande , statsforecasting released a new version with some breaking changes.

Try downgrading the package to see uf it fixes the issue:

pip install --upgrade statsforecast==0.6.0

@hrzn
Copy link
Contributor

hrzn commented Aug 2, 2022

Indeed, i missed this when carrying out the test above. This issue will be fixed in the new release of Darts: #1106

@hrzn hrzn closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants