Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Development pre-commit hooks throwing error #1577

Closed
RayDanks opened this issue Feb 19, 2023 · 0 comments
Closed

[BUG] Development pre-commit hooks throwing error #1577

RayDanks opened this issue Feb 19, 2023 · 0 comments
Labels
bug Something isn't working triage Issue waiting for triaging

Comments

@RayDanks
Copy link
Contributor

RayDanks commented Feb 19, 2023

Describe the bug
A change in Poetry means that the current version of isort is throwing errors - see below for the traceback:

`[INFO] Stashing unstaged files to /home/user/.cache/pre-commit/patch1676831322-474.
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Restored changes from /home/user/.cache/pre-commit/patch1676831322-474.
An unexpected error has occurred: CalledProcessError: command: ('/home/user/.cache/pre-commit/repou_gzncfm/py_env-python3/bin/python', '-mpip', 'install', '.')return code: 1
stdout:
Processing /home/user/.cache/pre-commit/repou_gzncfm
Installing build dependencies: started
Installing build dependencies: finished with status 'done'
Getting requirements to build wheel: started
Getting requirements to build wheel: finished with status 'done'
Preparing metadata (pyproject.toml): started
Preparing metadata (pyproject.toml): finished with status 'error'

stderr:
error: subprocess-exited-with-error

   Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      Traceback (most recent call last):
        File "/home/user/.cache/pre-commit/repou_gzncfm/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/home/user/.cache/pre-commit/repou_gzncfm/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "/home/user/.cache/pre-commit/repou_gzncfm/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
          return hook(metadata_directory, config_settings)
        File "/tmp/pip-build-env-r0qy3qtb/overlay/lib/python3.10/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel      
          poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
        File "/tmp/pip-build-env-r0qy3qtb/overlay/lib/python3.10/site-packages/poetry/core/factory.py", line 57, in create_poetry
          raise RuntimeError("The Poetry configuration is invalid:\n" + message)
      RuntimeError: The Poetry configuration is invalid:
        - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.`

The issue was described in this GitHub comment, as well as the hotfix:
PyCQA/isort#2083 (comment)

To Reproduce

  1. Install dev requirements as described in contributing.md
  2. Run pre-commit install, which should complete successfully
  3. Make a change to the repo, and commit using: git commit -m "any message"

Expected behavior
The pre-commit hooks should check the commit and complete correctly.

System (please complete the following information):

  • Python version: 3.10.6
  • darts version Current master branch, not installed via manager

Additional context
This issue is because the repo specifies that the isort used is version 5.10.1. The solution to this problem, as described in the attached issue comment, is to upgrade isort to version 5.11.5, to include the hotfix. I have done this in the following PR:
#1578

@RayDanks RayDanks added bug Something isn't working triage Issue waiting for triaging labels Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Issue waiting for triaging
Projects
None yet
Development

No branches or pull requests

2 participants