-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gridlines automatically created in matplotlib and seaborn plots [BUG] #2380
Comments
Hi @ETTAN93, when importing anything from Darts, we change the matplotlib settings/style for plotting. Like below
There were already some discussion about not changing the style by default (see #924). Maybe we should apply this at some point. @madtoinou what do you think about this? |
I agree that not changing the global config would be better, especially if users use Darts in the context of large projects in combination with other plotting libraries. |
Hi @madtoinou and @dennisbader, I'm not sure if this is a related issue but I think it is also related to plotting functions that are provided by Darts. For example, I have set Example 1: Example 2:
The formatting of the diagrams are all over the place. |
@ETTAN93 you may provide a full reproducible example. I think some other library or code is messing with the matplot parameters in your case. At least i can not reproduce it. And if so, it may be better to open a separate issue. import os
# Make sure to set this env variable BEFORE importing darts!
os.environ.setdefault("DARTS_CONFIGURE_MATPLOTLIB", "0")
import darts
from darts.utils.statistics import plot_residuals_analysis
import numpy as np
ts = darts.TimeSeries.from_values(np.array([0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9]))
plot_residuals_analysis(ts) |
@madtoinou @dennisbader I may can work on this, but would need some more information:
I personally would prefer the first one (and only custom plots if its really necessary or helpful. Like e.g. adding a grid). Because it's much easier and less error prone At least the |
Darts package seems to have some parameter under the hood that inserts gridlines into every matplotlib and seaborn plot:
If i do not import darts, this seaborn heatmap doesnt show gridlines,
However, if I include darts import as part of the imports, gridlines will appear in the plot:
Is there a reason why it's implemented this way?
The text was updated successfully, but these errors were encountered: