-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How are samples generated with RegressionModel / MLPRegressor? #2461
Comments
Hi @dwolffram, Can you please share a reproducible code snippet? If the model is not probabilistic, it should indeed not be able to generate samples but I might be missing something... |
Hi @madtoinou, that's what I thought, but somehow I get samples anyway 😅 Or am I doing something wrong?
|
I just realized that if I set |
I did a bit of investigation and this is the combination of several things;
An easy way to prevent this would just add some sanity check on the |
Thanks for looking into it! |
Madtoinou, why are the quantiles so wide then? Wouldn't 1000 identical predictions imply zero uncertainty? |
Because there are still |
Hi there,
I tried sklearn's
MLPRegressor
with theRegressionModel
wrapper, and to my surprise, I was able to generate samples withhistorical_forecasts
(e.g. withnum_samples = 1000
). How is this possible? NeitherRegressionModel
norMLPRegressor
accepts any kind of likelihood or loss function as an argument or am I missing something?model.supports_probabilistic_prediction
is actually false in my case but I can still generate samples.I would be happy to use this but it is not officially supported, right?
The text was updated successfully, but these errors were encountered: