Skip to content

Commit f0059a0

Browse files
committed
Fix issues uncovered when going through a fresh install.
1 parent 8242e19 commit f0059a0

File tree

4 files changed

+25
-15
lines changed

4 files changed

+25
-15
lines changed

common/variables.tf

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
11
variable "unity_instance" {
2-
# This should match the VPC name
3-
# Example Value: "Unity-Dev"
4-
description = "Name of the Unity instance where deploying"
2+
description = "Name of the Unity instance where deploying, must match the VPC name"
53
type = string
4+
# Example Value: "Unity-Dev"
65
}
76

87
variable "tenant_identifier" {
9-
# String inserted into many different resource names
10-
# Example Value: "development"
11-
description = "String identifying the tenant for which resources are created"
12-
type = string
13-
}
14-
15-
variable "resource_prefix" {
16-
description = "String used at the beginning of the names for all resources to identify them according to the UADS subsystem"
8+
description = "String identifying the tenant for which resources are created, string inserted into generated resource names"
179
type = string
18-
default = "uads"
10+
# Example Value: "development"
1911
}
2012

2113
variable "s3_identifier" {
2214
description = "String used in S3 bucket names to differentiate them between deployment venues"
2315
type = string
24-
default = "dev"
16+
# Example value: "dev"
2517
}
2618

2719
variable "efs_identifier" {
2820
description = "EFS file system to connect Jupyter shared storage with"
2921
type = string
3022
default = "uads-development-efs-fs"
23+
# Example value:uads-development-efs-fs"
24+
}
25+
26+
variable "resource_prefix" {
27+
description = "String used at the beginning of the names for all resources to identify them according to the UADS subsystem"
28+
type = string
29+
default = "uads"
3130
}
3231

3332
variable "availability_zone_1" {

dev_env/cognito/jupyter_uri_env.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ if [ -z "$(which terraform 2>/dev/null)" ]; then
1010
exit 1
1111
fi
1212

13-
cd $(realpath $script_dir/..)/jupyterlab
13+
cd $(realpath $script_dir/..)/jupyterhub
1414

1515
jupyter_uri=$(terraform output -raw jupyter_base_uri)
1616

17-
echo "export TF_VAR_jupyter_base_uri=\"${jupyter_uri}\""
17+
echo "export TF_VAR_jupyter_base_url=\"${jupyter_uri}\""

dev_env/jupyterhub/eks_cluster.tf

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,7 @@ resource "aws_autoscaling_attachment" "autoscaling_attachment" {
5151
autoscaling_group_name = lookup(lookup(lookup(aws_eks_node_group.jupyter_cluster_node_group, "resources")[0], "autoscaling_groups")[0], "name")
5252
lb_target_group_arn = aws_lb_target_group.jupyter_alb_target_group.arn
5353
}
54+
55+
output "eks_cluster_name" {
56+
value = aws_eks_cluster.jupyter_cluster.name
57+
}

dev_env/shared_storage/efs.tf

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,10 @@ resource "aws_efs_file_system" "dev_support_efs" {
66
Name = "${var.efs_identifier}"
77
}
88
}
9+
10+
resource "aws_efs_access_point" "jupyter_shared" {
11+
file_system_id = aws_efs_file_system.dev_support_efs.id
12+
root_directory {
13+
path = "/shared"
14+
}
15+
}

0 commit comments

Comments
 (0)