display error messages in UI, fix #16 clear old node data, browse parent folder if current target folder is not available, automatically set output file extension based on output format dropdown selection, #BUILD

Author: unitycoder

MainWindow.xaml

@@ -14,7 +14,7 @@
         <Button x:Name="btnBrowseOutput" Content="..." HorizontalAlignment="Left" Margin="636,114,0,0" VerticalAlignment="Top" Width="32" Height="23" Click="btnBrowseOutput_Click" ToolTip="Browse for output file"/>
         <TextBox x:Name="txtOutput" HorizontalAlignment="Left" Height="23" Margin="20,114,0,0" VerticalAlignment="Top" Width="611"/>
         <Label x:Name="label_Copy" Content="Output:" HorizontalAlignment="Left" Margin="20,88,0,0" VerticalAlignment="Top" Foreground="{DynamicResource MainText}"/>
-        <ComboBox x:Name="cmbExportFormat" HorizontalAlignment="Left" Margin="719,114,0,0" VerticalAlignment="Top" Width="163" IsReadOnly="True"/>
+        <ComboBox x:Name="cmbExportFormat" HorizontalAlignment="Left" Margin="719,114,0,0" VerticalAlignment="Top" Width="163" IsReadOnly="True" SelectionChanged="cmbExportFormat_SelectionChanged"/>
         <Label x:Name="label_Copy1" Content="Export format:&#xD;&#xA;" HorizontalAlignment="Left" Margin="719,88,0,0" VerticalAlignment="Top" Foreground="{DynamicResource MainText}" Height="26"/>
         <ComboBox x:Name="cmbImportFormat" HorizontalAlignment="Left" Margin="719,48,0,0" VerticalAlignment="Top" Width="163" IsReadOnly="True"/>
         <Label x:Name="label_Copy2" Content="Import format:&#xA;" HorizontalAlignment="Left" Margin="719,22,0,0" VerticalAlignment="Top" Foreground="{DynamicResource MainText}" Height="26"/>

MainWindow.xaml.cs

@@ -9,12 +9,13 @@
 using System.Runtime.InteropServices;
 using System.Threading;
 using System.Windows;
+using System.Windows.Controls;
 
 namespace PointCloudConverter
 {
     public partial class MainWindow : Window
     {
-        static string appname = "PointCloud Converter v1.74";
+        static string appname = "PointCloud Converter v1.75";
         static readonly string rootFolder = AppDomain.CurrentDomain.BaseDirectory;
 
         // allow console output from WPF application https://stackoverflow.com/a/7559336/5452781
@@ -281,10 +282,9 @@ void StartProcess(bool doProcess = true)
 
             // check input files
             var importSettings = ArgParser.Parse(args.ToArray(), rootFolder);
-            // TODO get error messages into log textbox (return in settings?)
 
             // if have files, process them
-            if (importSettings != null)
+            if (importSettings.errors.Count == 0)
             {
                 // show output settings for commandline
                 var cl = string.Join(" ", args);
@@ -303,7 +303,7 @@ void StartProcess(bool doProcess = true)
             else
             {
                 HideProcessingPanel();
-                txtConsole.Text = "Operation failed! Errors in arguments.";
+                txtConsole.Text = "Operation failed! " + string.Join(Environment.NewLine, importSettings.errors);
             }
         }
 
@@ -342,7 +342,40 @@ private void btnBrowseOutput_Click(object sender, RoutedEventArgs e)
             var dialog = new SaveFileDialog();
             dialog.Title = "Set output folder and filename";
             dialog.Filter = "UCPC (V2)|*.ucpc|PCROOT (V3)|*.pcroot";
-            dialog.InitialDirectory = Properties.Settings.Default.lastExportFolder;
+
+            // take folder from field
+            if (string.IsNullOrEmpty(txtOutput.Text) == false)
+            {
+                // check if folder exists, if not take parent folder
+                if (Directory.Exists(Path.GetDirectoryName(txtOutput.Text)) == true)
+                {
+                    dialog.InitialDirectory = txtOutput.Text;
+                }
+                else
+                {
+                    var folder = Path.GetDirectoryName(txtOutput.Text);
+                    // fix slashes
+                    folder = folder.Replace("\\", "/");
+                    for (int i = folder.Length - 1; i > -1; i--)
+                    {
+                        if (folder[i] == '/')
+                        {
+                            if (Directory.Exists(folder.Substring(0, i)))
+                            {
+                                dialog.InitialDirectory = folder.Substring(0, i).Replace("/", "\\");
+                                break;
+                            }
+                        }
+                    }
+                }
+            }
+            else // no path
+            {
+                dialog.InitialDirectory = Properties.Settings.Default.lastExportFolder;
+            }
+
+            Console.WriteLine(dialog.InitialDirectory);
+
             if (dialog.ShowDialog() == true)
             {
                 txtOutput.Text = dialog.FileName;
@@ -438,5 +471,11 @@ private void BtnCancel_Click(object sender, RoutedEventArgs e)
                 Environment.Exit(Environment.ExitCode);
             }
         }
+
+        private void cmbExportFormat_SelectionChanged(object sender, SelectionChangedEventArgs e)
+        {
+            // updatae file extension, if set
+            txtOutput.Text = Path.ChangeExtension(txtOutput.Text, "." + cmbExportFormat.SelectedValue.ToString().ToLower());
+        }
     } // class
 } // namespace

Structs/ImportSettings.cs

@@ -13,7 +13,7 @@ public class ImportSettings
         public IWriter writer = new UCPC();
 
         public bool haveError = false; // if errors during parsing args
-        public string[] errorMessages = null; // last error message(s)
+        //public string[] errorMessages = null; // last error message(s)
 
         public bool useScale = false;
         public float scale = 1f;
@@ -24,6 +24,8 @@ public class ImportSettings
         public List<string> inputFiles = new List<string>();
         public string outputFile = null;
 
+        public List<string> errors = new List<string>(); // return errors to UI
+
         // FIXME default values will be used unless otherwise specified.. randomize = true 
         // TODO these should be export settings..
 

Tools/ArgParser.cs

@@ -620,13 +620,11 @@ public static ImportSettings Parse(string[] args, string rootFolder)
                     Console.WriteLine(i + "> " + errors[i]);
                 }
                 Console.ForegroundColor = ConsoleColor.White;
-
-                return null;
-            }
-            else
-            {
-                return importSettings;
+                importSettings.errors = errors;
             }
+
+            // return always, but note that we might have errors
+            return importSettings;
         }
     }
 }

Writers/PCROOT.cs

@@ -38,13 +38,17 @@ bool IWriter.InitWriter(ImportSettings _importSettings, int _pointCount)
             var res = true;
 
             // clear old nodes
+            nodeBounds.Clear();
             nodeX.Clear();
             nodeY.Clear();
             nodeZ.Clear();
             nodeR.Clear();
             nodeG.Clear();
             nodeB.Clear();
 
+            bsPoints = null;
+            writerPoints = null;
+
             cloudMinX = float.PositiveInfinity;
             cloudMinY = float.PositiveInfinity;
             cloudMinZ = float.PositiveInfinity;
@@ -317,7 +321,7 @@ void IWriter.Save(int fileIndex)
                 var tilerootdata = new List<string>();
                 var outputFileRoot = Path.Combine(baseFolder, fileOnly) + ".pcroot";
 
-                // add to tileroot list
+                // add to tileroot listS
                 long totalPointCount = 0;
                 for (int i = 0, len = nodeBounds.Count; i < len; i++)
                 {