Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Order on Hub and version #217

Open
1 task done
Fr-Dae opened this issue Oct 9, 2023 · 14 comments
Open
1 task done

[BUG] Order on Hub and version #217

Fr-Dae opened this issue Oct 9, 2023 · 14 comments

Comments

@Fr-Dae
Copy link

Fr-Dae commented Oct 9, 2023

There is no other issue reporting the same problem.

  • I have searched the existing issues

Game HUB Version

933

I was

User

OS

Linux
OS: Lubuntu 22.04x64
Kernel: 5.15.0-86-generic
Memory: 16Gio Ram
CPU: Intel i7-6700HQ (8) @ 3.500GHz
GPU: NVIDIA GeForce GTX 960M

What happened?

I've spotted several bugs in the Station Hub.

  • it's not possible to organize builds (and it's not done by default) the most recent should be in 1st position and have a descending order
  • the list is limited to a certain number for no reason
  • manually add a folder in ~/.local/share/StationHub/Installations/UnitystationDevelop/23100715/
    even if you follow the folder naming norms exactly, the build is not added to the list (you have to run it manually from locale)

Capture d’écran du 2023-10-09 06-57-00
Capture d’écran du 2023-10-09 06-57-19

@MaxIsJoe
Copy link
Contributor

MaxIsJoe commented Oct 9, 2023

Post this issue on the stationhub repo

@MaxIsJoe MaxIsJoe closed this as completed Oct 9, 2023
@Fr-Dae
Copy link
Author

Fr-Dae commented Oct 9, 2023

you know you have a button on the right to transfer issues from one repo to another? rather than closing an issue that is NOT resolved?

@MaxIsJoe
Copy link
Contributor

MaxIsJoe commented Oct 9, 2023

image

no

@Fr-Dae
Copy link
Author

Fr-Dae commented Oct 10, 2023

@corp-0 @Bod9001 could you transfert and re-open this issue please ?

@corp-0 corp-0 transferred this issue from unitystation/unitystation Oct 10, 2023
@corp-0 corp-0 reopened this Oct 10, 2023
@Fr-Dae
Copy link
Author

Fr-Dae commented Oct 10, 2023

th

@corp-0
Copy link
Member

corp-0 commented Oct 10, 2023

the list is limited to a certain number for no reason

what do you mean?

manually add a folder in ~/.local/share/StationHub/Installations/UnitystationDevelop/23100715/

does it work if you close and reopen hub?

@CorruptComputer
Copy link
Contributor

manually add a folder in ~/.local/share/StationHub/Installations/UnitystationDevelop/23100715/
even if you follow the folder naming norms exactly, the build is not added to the list (you have to run it manually from locale)

This will not work. You need to add it to the installations json file as well. Currently out at a restaurant so I can't check what this file is called.

@Fr-Dae
Copy link
Author

Fr-Dae commented Oct 10, 2023

dae@dae-GL753VD:~/local/share/StationHub/Installations$ tree -d -L 2 ./
./
├── Unitystation
│   ├── 4115
│   ├── 4121
│   └── 4124
└── UnityStationDevelop
    ├── 100461
    ├── 21110300
    ├── 21110423
    ├── 21111003
    ├── 21111117
    ├── 21112117
    ├── 22102218
    ├── 22102414
    ├── 22102800
    ├── 22110212
    ├── 22110505
    ├── 22111122
    ├── 22111216
    ├── 22112212
    ├── 22112621
    ├── 22112816
    ├── 22120122
    ├── 22120202
    ├── 22120304
    ├── 22121218
    ├── 22121502
    ├── 22121823
    ├── 22122405
    ├── 23010114
    ├── 23010719
    ├── 23011213
    ├── 23011320
    ├── 23011416
    ├── 23012310
    ├── 23012515
    ├── 23012615
    ├── 23012812
    ├── 23013009
    ├── 23013119
    ├── 23020118
    ├── 23020223
    ├── 23020418
    ├── 23020422
    ├── 23020819
    ├── 23022021
    ├── 23022319
    ├── 23022600
    ├── 23030314
    ├── 23030811
    ├── 23030914
    ├── 23031117
    ├── 23031718
    ├── 23031818
    ├── 23032020
    ├── 23040116
    ├── 23041602
    ├── 23042123
    ├── 23042416
    ├── 23051319
    ├── 23061102
    ├── 23061606
    ├── 23062012
    ├── 23062819
    ├── 23090316
    ├── 23091123
    ├── 23092112
    ├── 23092619
    ├── 23100715
    └── 23100719

here my full list of build i have in my collection.

@CorruptComputer
Copy link
Contributor

Go up a folder

@Fr-Dae
Copy link
Author

Fr-Dae commented Oct 10, 2023

manually add a folder in ~/.local/share/StationHub/Installations/UnitystationDevelop/23100715/
even if you follow the folder naming norms exactly, the build is not added to the list (you have to run it manually from locale)

This will not work. You need to add it to the installations json file as well. Currently out at a restaurant so I can't check what this file is called.

could you please explain step by step how to do it?

@Fr-Dae
Copy link
Author

Fr-Dae commented Oct 10, 2023

and also, on linux Ubuntu, what would be the command to retrieve the InstallationId list?
because parsing the version list is not complicated.
but the id I have no idea how to do.

@Fr-Dae
Copy link
Author

Fr-Dae commented Oct 10, 2023

new worries,
I went from this

[{"InstallationId":"4223ef5c-c9bc-4ea8-900a-08780ab3e625","ForkName":"Unitystation","BuildVersion":4124,"InstallationPath":"/home/dae/.local/share/StationHub/Installations/Unitystation/4124","LastPlayedDate":"2023-09-21T22:48:31.2166133+02:00"},{"InstallationId":"a0cb8e9a-03c2-4e49-9f29-0ee2b6cc50b9","ForkName":"UnityStationDevelop","BuildVersion":23061606,"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23061606","LastPlayedDate":"2023-10-08T18:39:17.7899657+02:00"},{"InstallationId":"9b2cc294-a51b-4053-bb67-e4446baf36fd","ForkName":"UnityStationDevelop","BuildVersion":23090316,"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23090316","LastPlayedDate":"2023-10-08T18:35:24.819684+02:00"},{"InstallationId":"034b4ede-e320-4ad9-8633-8f2b4c9e367e","ForkName":"UnityStationDevelop","BuildVersion":23091123,"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23091123","LastPlayedDate":"2023-10-08T18:31:31.4562329+02:00"},{"InstallationId":"dadf9a59-eddd-4e02-b748-aecabd7178aa","ForkName":"UnityStationDevelop","BuildVersion":23092112,"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23092112","LastPlayedDate":"2023-10-08T18:29:24.732788+02:00"},{"InstallationId":"192cc83b-b481-4c99-8fa0-f71aa565d321","ForkName":"UnityStationDevelop","BuildVersion":23092619,"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23092619","LastPlayedDate":"2023-10-08T18:56:02.1711361+02:00"},{"InstallationId":"1203538d-8503-4887-9da4-052735d15058","ForkName":"UnityStationDevelop","BuildVersion":100461,"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/100461","LastPlayedDate":"2023-10-09T08:47:21.3115714+02:00"}]

to this

[
{"InstallationId":"4223ef5c-c9bc-4ea8-900a-08780ab3e625",
"ForkName":"Unitystation",
"BuildVersion":4124,
"InstallationPath":"/home/dae/.local/share/StationHub/Installations/Unitystation/4124",
"LastPlayedDate":"2023-09-21T22:48:31.2166133+02:00"},

{"InstallationId":"a0cb8e9a-03c2-4e49-9f29-0ee2b6cc50b9",
"ForkName":"UnityStationDevelop",
"BuildVersion":23061606,
"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23061606",
"LastPlayedDate":"2023-10-08T18:39:17.7899657+02:00"},

{"InstallationId":"9b2cc294-a51b-4053-bb67-e4446baf36fd",
"ForkName":"UnityStationDevelop",
"BuildVersion":23090316,
"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23090316",
"LastPlayedDate":"2023-10-08T18:35:24.819684+02:00"},

{"InstallationId":"034b4ede-e320-4ad9-8633-8f2b4c9e367e",
"ForkName":"UnityStationDevelop",
"BuildVersion":23091123,
"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23091123",
"LastPlayedDate":"2023-10-08T18:31:31.4562329+02:00"},

{"InstallationId":"dadf9a59-eddd-4e02-b748-aecabd7178aa",
"ForkName":"UnityStationDevelop",
"BuildVersion":23092112,
"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23092112",
"LastPlayedDate":"2023-10-08T18:29:24.732788+02:00"},

{"InstallationId":"192cc83b-b481-4c99-8fa0-f71aa565d321",
"ForkName":"UnityStationDevelop",
"BuildVersion":23092619,
"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/23092619",
"LastPlayedDate":"2023-10-08T18:56:02.1711361+02:00"},

{"InstallationId":"1203538d-8503-4887-9da4-052735d15058",
"ForkName":"UnityStationDevelop",
"BuildVersion":100461,
"InstallationPath":"/home/dae/.local/share/StationHub/Installations/UnityStationDevelop/100461",
"LastPlayedDate":"2023-10-09T08:47:21.3115714+02:00"}
]

(I simply added line breaks after each one, )

the Station hub opens and the list is correct
I get this new error message when I want to download the new version.
Capture d’écran du 2023-10-10 02-57-35

@Fr-Dae
Copy link
Author

Fr-Dae commented Oct 10, 2023

Logs.zip

@CorruptComputer
Copy link
Contributor

it's not possible to organize builds (and it's not done by default) the most recent should be in 1st position and have a descending order

You are entirely correct on this, however I'm not sure much can be done about it unless the build date is published to the hub API along side the version number. Not all forks will use the same versioning scheme and if a new fork came along and started at version 1, it would be at the end of the list even if its build date is newer than some of the others.

the list is limited to a certain number for no reason

I don't think this is true, neither the installations list or the servers list has any sort of maximum number to them.

manually add a folder in ~/.local/share/StationHub/Installations/UnitystationDevelop/23100715/ even if you follow the folder naming norms exactly, the build is not added to the list (you have to run it manually from locale)

Yeah this is expected, what is in the installations folder is not what is shown in the launcher. The launcher shows the builds it has registered, and because the installations folder can be changed without moving your current installations, this method is no longer supported. I still have a 'build import' feature in mind, but I think it would be best to wait until the security system PR is done first so that these random builds being registered can be scanned and marked as safe.

image

As for the error you recieved here, I think this is working as expected. You already put this build in the folder manually, I can see it in the tree you did. └── 23100719
image

So when you click on download, it looks and sees that the folder name of the version you are trying to download already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants