Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect config file updated using the updateConfig function when cwd is missing a trailing slash #187

Closed
abhi12299 opened this issue Sep 3, 2024 · 2 comments · Fixed by #188
Closed

Incorrect config file updated using the updateConfig function when cwd is missing a trailing slash #187

abhi12299 opened this issue Sep 3, 2024 · 2 comments · Fixed by #188
Labels
bug Something isn't working

Comments

@abhi12299
Copy link

Environment

Node: v20.8.1
c12: 2.0.0-beta.1

Reproduction

This issue was identified in the nuxt repo: nuxt/nuxt#28797

Link to reproduce the issue: https://stackblitz.com/edit/stackblitz-starters-ea59nb?file=README.md

Describe the bug

Without a trailing slash at the end of cwd, the updateConfig ends up modifying the wrong file.

Additional context

No response

Logs

No response
@abhi12299 abhi12299 added the bug Something isn't working label Sep 3, 2024
@pi0 pi0 mentioned this issue Sep 3, 2024
Merged
@pi0
Copy link
Member

pi0 commented Sep 3, 2024

Thanks for nice report. fixed in latest 1.x (and v2 beta)

@pi0 pi0 closed this as completed Sep 3, 2024
@n0099
Copy link

n0099 commented Sep 10, 2024 •
edited
Loading

v2 branch: 5b0c89c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(updateConfig): properly resolve config relative to cwd unjs/c12
3 participants
@pi0 @n0099 @abhi12299