Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support version update of package-lock.json and npm-shrinkwrap.json #194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support version update of package-lock.json and npm-shrinkwrap.json #194

wants to merge 1 commit into from

Conversation

odanado
Copy link

@odanado odanado commented May 31, 2024

🔗 Linked issue

#193

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I have updated the version fields in package-lock.json and npm-shrinkwrap.json as well as package.json.

Resolves #193

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

odanado
odanado commented Jun 5, 2024
View reviewed changes
src/semver.ts

if (pkgLock.packages && pkgLock.packages[""]) {
pkgLock.packages[""].version = pkg.version;
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: https://github.com/npm/cli/blob/60faa9052a74d7a6ac8db59dae2d7017542310d7/workspaces/libnpmversion/lib/version.js#L79-L94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support version update of package-lock.json and npm-shrinkwrap.json
1 participant
@odanado