Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelogen release-ci to auto release (pkg.pr.new) #215

Open
1 task
pi0 opened this issue Aug 17, 2024 · 8 comments
Open
1 task

changelogen release-ci to auto release (pkg.pr.new) #215

pi0 opened this issue Aug 17, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Aug 17, 2024

Describe the feature

We can introduce changelogen release-ci that triggers release on each CI run.

pkg.pr.new could be first provider but i am thinking that we design internal impl to be provider agnostic. (if defined as a direct fetch specification that would be perfect, we can use npm pack + POST)

/cc @Aslemammad if you had time before me to pick on this, i would love to have it 🙏🏼

Additional information

  • Would you be willing to help implement this feature?
@pi0 pi0 added the enhancement New feature or request label Aug 17, 2024
@pi0 pi0 changed the title changelogen --ci to auto release with pkg.pr.new changelogen --ci to auto release (pkg.pr.new) Aug 17, 2024
@pi0 pi0 changed the title changelogen --ci to auto release (pkg.pr.new) changelogen release-ci to auto release (pkg.pr.new) Aug 17, 2024
@Aslemammad
Copy link

Aslemammad commented Aug 20, 2024

I love this, what do you think about changelogen preview as a command?

And under the hood, we just run pkg.pr.new publish and pass the arguments there.

@pi0
Copy link
Member Author

pi0 commented Aug 20, 2024

I love this, what do you think about changelogen preview as a command?

Love preview 💯

And under the hood, we just run pkg.pr.new publish and pass the arguments there.

Do you think maybe it would be hard to use a fetch call to pkg.pr.new + npm pack? 🙏🏼

@Aslemammad
Copy link

Do you think maybe it would be hard to use a fetch call to pkg.pr.new + npm pack? 🙏🏼

It's doable, but yea, it's hard, since the command line does so much and only small part of it is the fetch call!

@pi0
Copy link
Member Author

pi0 commented Sep 5, 2024

@Aslemammad Considering all the limitations, still if you can give me an overall idea about how we can directly upload a tarball to pkg.pr.new registry API I would love to make this happen 🙏🏼

(the long-term goal is to make changelogen independent from registry CLIs. I am also working to find a solution to removing the npm CLI dependency as well from changelogen that's why it is important, even if means less features at first)

@Aslemammad
Copy link

Ok, I can do it by the next two weeks hopefully if you want! I'd be happy to.

But the most important thing is generating the hash for the workflow environment!

And if that hash is the correct hash that was also generated asymmetrically in the server, then pkg.pr.new would allow you to publish.

https://github.com/stackblitz-labs/pkg.pr.new/blob/main/packages/cli/index.ts#L364-L376

See sb-key.

Let me know what do you think.

@Aslemammad
Copy link

I have an idea, what if I make a export pkg.pr.new/utils that gets directories/templates and publishes them? In such case, we'd need to install the pkg.pr.new dependency (an optional dep?). And then dynamic import it.

Would that still be allowed? What do you think?

It'd make the job way easier.

@Aslemammad
Copy link

I'll send a pkg.pr.new for preview on changelogen so I can try experimenting!

@pi0
Copy link
Member Author

pi0 commented Sep 18, 2024

Thanks for initiating work on this dear @Aslemammad. Ideally, if it would be possible to avoid direct dependency (but depending on the API contract only) it would be best and future-proof.

(feel free to DM me in discord if you like to chat)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants