-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelogen release-ci
to auto release (pkg.pr.new
)
#215
Comments
changelogen --ci
to auto release with pkg.pr.new
changelogen --ci
to auto release (pkg.pr.new
)
changelogen --ci
to auto release (pkg.pr.new
)changelogen release-ci
to auto release (pkg.pr.new
)
I love this, what do you think about And under the hood, we just run |
Love
Do you think maybe it would be hard to use a fetch call to |
It's doable, but yea, it's hard, since the command line does so much and only small part of it is the fetch call! |
@Aslemammad Considering all the limitations, still if you can give me an overall idea about how we can directly upload a tarball to pkg.pr.new registry API I would love to make this happen 🙏🏼 (the long-term goal is to make changelogen independent from registry CLIs. I am also working to find a solution to removing the npm CLI dependency as well from changelogen that's why it is important, even if means less features at first) |
Ok, I can do it by the next two weeks hopefully if you want! I'd be happy to. But the most important thing is generating the hash for the workflow environment! And if that hash is the correct hash that was also generated asymmetrically in the server, then pkg.pr.new would allow you to publish. https://github.com/stackblitz-labs/pkg.pr.new/blob/main/packages/cli/index.ts#L364-L376 See Let me know what do you think. |
I have an idea, what if I make a export Would that still be allowed? What do you think? It'd make the job way easier. |
I'll send a pkg.pr.new for preview on changelogen so I can try experimenting! |
Thanks for initiating work on this dear @Aslemammad. Ideally, if it would be possible to avoid direct dependency (but depending on the API contract only) it would be best and future-proof. (feel free to DM me in discord if you like to chat) |
Describe the feature
We can introduce
changelogen release-ci
that triggers release on each CI run.pkg.pr.new could be first provider but i am thinking that we design internal impl to be provider agnostic. (if defined as a direct fetch specification that would be perfect, we can use
npm pack
+ POST)/cc @Aslemammad if you had time before me to pick on this, i would love to have it 🙏🏼
Additional information
The text was updated successfully, but these errors were encountered: