Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject NODE_ENV with production value by default for production runtime #2046

Open
pi0 opened this issue Jan 2, 2024 · 0 comments
Open

Inject NODE_ENV with production value by default for production runtime #2046

pi0 opened this issue Jan 2, 2024 · 0 comments
Labels
enhancement New feature or request node

Comments

@pi0
Copy link
Member

pi0 commented Jan 2, 2024

Ref nuxt/nuxt#23402

While nitro externals tracer rewrites exports conditions to production (#844), in runtime of some externals there are still manual check for NODE_ENV. (hopefully, some day they use exports conditions with production support to remove need of this)

This is an alternative of previously PR #605 to inject only at runtime which is our more specific concern also works for all node runtimes without depending on commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request node
Projects
None yet
Development

No branches or pull requests

1 participant