-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support jsx
and tsx
out of the box
#1303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
fix(esbuild): add missing jsxFactory and jsxFragment options
feat: support jsx
Jun 20, 2023
Codecov Report
@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
+ Coverage 76.62% 76.69% +0.06%
==========================================
Files 69 70 +1
Lines 7081 7100 +19
Branches 706 705 -1
==========================================
+ Hits 5426 5445 +19
Misses 1654 1654
Partials 1 1
|
pi0
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and great idea! I have made few more changes to make it working out of the box preconfigured.
pi0
changed the title
feat: support
feat: support Jun 20, 2023
jsx
and tsx
jsx
and tsx
out of the box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Related to #1299
β Type of change
π Description
Nitro esbuild options presents with type definitions of
jsxFactory
andjsxFragment
, but they never used anywhere at codebase really. This PR adds those missing options to esbuildtransform
method. This will allow use jsx syntax with other libraries/frameworks besides React. As an example: Vue with jsx, Preact, nano-jsx and others.I also committed nano-jsx SSR example.
Resolves #1299
π Checklist