-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(vercel): add note about top level api/
directory
#1386
Conversation
✅ Live Preview ready!
|
Codecov Report
@@ Coverage Diff @@
## main #1386 +/- ##
==========================================
- Coverage 76.73% 76.37% -0.36%
==========================================
Files 71 71
Lines 7273 7273
Branches 727 721 -6
==========================================
- Hits 5581 5555 -26
- Misses 1691 1717 +26
Partials 1 1 |
This is welcomed, altough this is mentioned in the docs already here: https://nitro.unjs.io/guide/routing, it's easy to miss. |
Thanks! I was a little confused by this page. I'm very new to the project so I assume this might be obvious for more seasoned nuxt devs who are familiar with nitro. Are you talking about this quote from the page you linked?
|
That's the one yes ! |
Ok, perhaps then I'll add to the original quote. |
@Hebilicious I reworded the original documentation. What do you think? |
@rieger-jared I liked your initial idea of adding more instructions within Vercel, so I added a section there. Does this looks more comprehensible to you ? |
Yeah, looks good to me! I think it's also good that we include it in the deployment section as I'm sure most people won't hold the link between the doc sections. Thank you for adding that back in! |
api/
directory
❤️ |
After following the initial project scaffolded via the command
npx giget@latest nitro nitro-app
I found that after deploying to vercel viavercel
command my routes were not at the expected place of domian.com/api/hello/.I added this documentation to hopefully help future developers wishing to deploy to vercel not waste time understanding the mapping of routes.
I found the solution via this GitHub discussion
#233
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist