-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto capture errors with nitroApp.captureError
#1463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
+ Coverage 76.14% 76.21% +0.06%
==========================================
Files 73 73
Lines 7428 7433 +5
Branches 728 728
==========================================
+ Hits 5656 5665 +9
+ Misses 1771 1767 -4
Partials 1 1
|
atinux
approved these changes
Jul 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This PR allows capturing errors both automatically (for all requests + plugins + cache operations + node unhandled errors) and also manually using
useNitroApp().captureError(error, { event, tags? })
andevent.captureError(error, { tags? })
APIs.It can be used to make a nitro plugin with integrations to external logging systems or custom log handling using new
error
hook (useNitroApp().hooks.hook('error', (error, context) => {})
.Async hooks will run in parallel and background for performance and also be captured using
event.waitUntil
to prevent timeouts on worker environments.π Checklist