Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vercel): enable streaming support out of the box #1514

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jul 31, 2023

πŸ”— Linked issue

resolves #1505

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR improve js docs for vercel sls config and also enables supportsResponseStreaming flag by default (can be disabled by user).

Now that we are using a h3 version that is compatible with streaming, we can safely enable streaming. I have requested vercel team to verify this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1514 (7734365) into main (e8e806a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1514      +/-   ##
==========================================
+ Coverage   76.25%   76.26%   +0.01%     
==========================================
  Files          73       73              
  Lines        7462     7466       +4     
  Branches      732      732              
==========================================
+ Hits         5690     5694       +4     
  Misses       1771     1771              
  Partials        1        1              
Files Changed Coverage Ξ”
src/presets/vercel.ts 92.90% <100.00%> (+0.09%) ⬆️

@pi0 pi0 merged commit 6217581 into main Jul 31, 2023
6 checks passed
@pi0 pi0 deleted the feat/vercel-streaming branch July 31, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant