-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: experimental composition api via useEvent()
ans async context support
#1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks π
β Live Preview ready!
|
pi0
changed the title
feat: experimental composition api via
feat: experimental composition api via Aug 7, 2023
useEvent()
, unctx and async local storageuseEvent()
ans async context support
Codecov Report
@@ Coverage Diff @@
## main #1546 +/- ##
==========================================
- Coverage 76.38% 76.35% -0.03%
==========================================
Files 73 73
Lines 7550 7558 +8
Branches 745 744 -1
==========================================
+ Hits 5767 5771 +4
- Misses 1782 1785 +3
- Partials 1 2 +1
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This PR enables a new experiment using unctx native local storage support to enable a new development pattern similar to vue composition API to make server events available in every async context using
useEvent()
without need to passing it directly around.Before:
After:
Note: This feature is currently supported for Node.js environments.
π Checklist