ci: use h3-nightly@latest for edge releases
#1563
Conversation
pi0
changed the title
h3-nightly for edge releases
Codecov Report
@@ Coverage Diff @@
## main #1563 +/- ##
=======================================
Coverage 76.49% 76.49%
=======================================
Files 73 73
Lines 7582 7582
Branches 752 752
=======================================
Hits 5800 5800
Misses 1781 1781
Partials 1 1 |
pi0
changed the title
h3-nightly for edge releasesh3-nightly@latest for edge releases
| @@ -117,6 +119,11 @@ async function main() { | |||
| `${pkg.data.version}-${date}.${commit}` | |||
| ); | |||
| workspace.rename(pkg.data.name, pkg.data.name + "-edge"); | |||
| pkg.updateDeps((dep) => { | |||
| if (nightlyPackages[dep.name]) { | |||
| dep.range = "npm:" + nightlyPackages[dep.name] + "@latest"; | |||
There was a problem hiding this comment.
see my comment at nuxt/nuxt#22593 (comment).
I'm not sure latest is safe here. I'd recommend a caret + version hash.
There was a problem hiding this comment.
Also see my comment there! I think it should be safer than pinned version to avoid hoisting issues on edge.
There was a problem hiding this comment.
Reposting from nuxt/nuxt#22593 (comment), caret + hash is respected by package manager in a way that it won't look for any newer version + (sadly) h3-nightly@^1 doesn't works with packages published with - version.
pi0
force-pushed
the
chore/ci-h3-nightly
branch
from
e0533dd
to
ef87b52
Compare
|
Merging to test end-to-end with the package manager behavior + coupled with nuxt edge. I think if it is introducing too much trouble, we shall revert it and keep using |
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist