Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use decoded asset id to access prerendered asset header overrides #1588

Merged
merged 9 commits into from
Aug 16, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add test - sorry!

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title feat: preserve prerendered asset content-type header test: add test for content-type Aug 16, 2023
@danielroe danielroe changed the title test: add test for content-type fix: use decoded asset id to access prerendered asset header overrides Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1588 (3379c2c) into main (39851b8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1588   +/-   ##
=======================================
  Coverage   76.26%   76.26%           
=======================================
  Files          76       76           
  Lines        7799     7799           
  Branches      781      781           
=======================================
  Hits         5948     5948           
  Misses       1849     1849           
  Partials        2        2           
Files Changed Coverage Ξ”
src/rollup/plugins/public-assets.ts 92.68% <100.00%> (ΓΈ)

@pi0 pi0 merged commit 00361fb into main Aug 16, 2023
8 checks passed
@pi0 pi0 deleted the feat/asset-content-type branch August 16, 2023 10:44
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants