Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static): send immediate empty responses for 304 handling #1639

Merged
merged 3 commits into from
Aug 26, 2023
Merged

fix(static): send immediate empty responses for 304 handling #1639

merged 3 commits into from
Aug 26, 2023

Conversation

markthree
Copy link
Contributor

πŸ”— Linked issue

#1638

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It just changes send(event, "") to return "" in 304。

It seems to be a problem with h3, if it returns undefined it will automatically jump to the next middleware

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix(runtime/static): fix occasional 404 after build, close #1638 fix(static): send immediate empty responses for 304 handling Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #1639 (0e7e02d) into main (b1e676e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1639   +/-   ##
=======================================
  Coverage   77.76%   77.76%           
=======================================
  Files          76       76           
  Lines        7824     7824           
  Branches      803      803           
=======================================
  Hits         6084     6084           
  Misses       1738     1738           
  Partials        2        2           

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 03f5963 into nitrojs:main Aug 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants