Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests against node 18 #1713

Merged
merged 1 commit into from
Sep 11, 2023
Merged

ci: run tests against node 18 #1713

merged 1 commit into from
Sep 11, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 11, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Node.js 16 is almost EOL. We don't plan to "force upgrade" users by deliberately breaking Node.js 16 but also not guarantee supporting things working in EOL versions of Node.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1713 (9fc28a1) into main (6b5f1d1) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
- Coverage   77.29%   77.27%   -0.03%     
==========================================
  Files          75       75              
  Lines        7893     7893              
  Branches      805      806       +1     
==========================================
- Hits         6101     6099       -2     
- Misses       1790     1792       +2     
  Partials        2        2              

see 1 file with indirect coverage changes

@pi0 pi0 merged commit f84c282 into main Sep 11, 2023
9 checks passed
@pi0 pi0 deleted the ci/node-18 branch September 11, 2023 17:28
@pi0 pi0 mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant