Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iis): improve preset and docs #1784

Merged
merged 1 commit into from
Oct 3, 2023
Merged

refactor(iis): improve preset and docs #1784

merged 1 commit into from
Oct 3, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 3, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

While testing IIS presets locally, found some issues around IIS presets. I might have missed some tips to included as is happened over days (For example Feature Delegations needs configured to make config working) -- If anyone interested to improve details is more than welcome!

Changes summary:

  • Add iis_handler alias (was being in docs but available as iis)
  • Remove the "Recommended" banner from IISNode (strangely this module is rusty as hell! not sure how azure is still depending on this! And handler setup was much smoother)
  • Added comments to iis-node XML (from original article. it was so helpful)
  • Disabled logging/debugging for production IIS (first, logs should not be exposed to production and second, a default windows server setup was making errors -- happy to add it back if someone can figure out and add easy docs for logging)

/cc @antony-k1208 As you first implemented IIS presets, if you are interested to take over more active maintenance, please reach me out in discord via pi0.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Oct 3, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview ffccc41

@pi0 pi0 merged commit f2d0c7d into main Oct 3, 2023
4 of 6 checks passed
@pi0 pi0 deleted the refactor/iis branch October 3, 2023 16:17
@pi0 pi0 mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant