-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(prerender): decode html entities in rendered links #1824
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
+ Coverage 52.24% 52.41% +0.17%
==========================================
Files 170 170
Lines 11754 11759 +5
Branches 900 906 +6
==========================================
+ Hits 6141 6164 +23
+ Misses 5516 5499 -17
+ Partials 97 96 -1
|
Thanks! Do you mind to add an example link in test fixtures as well? (we have a list of both valid + invalid examples in prerender route) |
π Linked issue
β Type of change
π Description
I'm still investigating whether there's also something to be fixed in nuxt or vue-router, but it seems Vue router can in some circumstances render
&
for&
within hrefs, and Nitro (by passing this literally rather than as the browser interprets it) can trigger infinite loops of prerendering, generating links like/enterprise/agencies?region=europe&service=ecommerce&service=ecommerce&service=content-marketing
.Example: https://stackblitz.com/edit/github-6rieuk?file=pages/index.vue (run
npm run generate
)π Checklist