Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare-pages): filter out overlapping public assets dirs #1859

Merged
merged 5 commits into from
Oct 28, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #1844

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Cloudflare doesn't expect to have overlapping public assets dirs. This prevents using overlapping dirs, preferring instead the top level dir if it overlaps a child dir.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Oct 28, 2023
@danielroe danielroe requested a review from pi0 October 28, 2023 03:18
@danielroe danielroe self-assigned this Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1859 (f3c017c) into main (2d803a3) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
+ Coverage   52.09%   52.38%   +0.29%     
==========================================
  Files         170      170              
  Lines       11787    11806      +19     
  Branches      901      910       +9     
==========================================
+ Hits         6140     6185      +45     
+ Misses       5551     5525      -26     
  Partials       96       96              
Files Coverage Ξ”
src/presets/cloudflare-pages.ts 62.50% <100.00%> (+3.34%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (haven't tested locally but trust you did)

@pi0 pi0 merged commit 6c1570d into main Oct 28, 2023
9 checks passed
@pi0 pi0 deleted the fix/cloudflare-dirs branch October 28, 2023 12:07
@pi0 pi0 mentioned this pull request Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment to Cloudflare Pages broken with new Nuxt 3.8 app manifest feature
2 participants