Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zeabur): support zeaburStatic and auto detect preset #2014

Merged
merged 3 commits into from
Jan 4, 2024
Merged

feat(zeabur): support zeaburStatic and auto detect preset #2014

merged 3 commits into from
Jan 4, 2024

Conversation

yuaanlin
Copy link
Contributor

🔗 Linked issue

#1942

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently, nitro will not auto switching to zeabur preset when there is an environment variable ZEABUR=1.

This PR fixes this issue.

📝 Checklist

  • I have linked an issue or discussion.

@yuaanlin
Copy link
Contributor Author

Before

Screenshot 2023-12-20 at 12 36 06 PM

After

Screenshot 2023-12-20 at 12 35 18 PM

@pi0 pi0 changed the title fix(zeabur): Add zeabur to autodetectableProviders feat(zeabur): support zeaburStatic and auto detect preset Jan 4, 2024
pi0
pi0 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit 68ef5f5 into nitrojs:main Jan 4, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Feb 27, 2024
Closed
@Barbapapazes Barbapapazes mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuaanlin @pi0