Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import-meta): import process from node:process for node compatible builds (deno) #2225

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

littledivy
Copy link
Contributor

@littledivy littledivy commented Mar 7, 2024

πŸ”— Linked issue

#2224

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This commit adds an emitted import to the process global of the Node.js adapter output. This ensures the output can be used by Deno's Node compat layer.

Fixes #2224
Ref denoland/deno#22744

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Fixes denoland/deno#22744
Ref denoland/deno#22744

This commit adds an emitted import to the process global of the Node.js adapter output.
This ensures the output can be used by Deno's Node compat layer.
@pi0 pi0 changed the title fix: deno task dev compatibility fix(import-meta): import process from node:process for node compatible builds (deno) Mar 7, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 4ecd31f into nitrojs:main Mar 8, 2024
4 checks passed
@littledivy littledivy deleted the import_process branch March 8, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Nitro's Node.js mode with Deno
2 participants