Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify): allow writing config.json #2264

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Mar 15, 2024

πŸ”— Linked issue

Blocks nuxt/image#1287

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds support for writing Netlify config. Currently this only supports configuring image domains, but will eventually allow all configuration options. This is needed to support the domains option in nuxt/image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title feat(netlify): add support for writing Netlify options fix(netlify): allow writing config.json Mar 25, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as discussed internally, merging this as fix to land earlier and allow framework support for image config)

@pi0 pi0 merged commit eca05c8 into nitrojs:main Mar 25, 2024
4 checks passed
@ascorbic ascorbic deleted the netlify-options branch March 25, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants