Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about middleware execution order #2282

Merged
merged 4 commits into from
Mar 20, 2024
Merged

docs: add note about middleware execution order #2282

merged 4 commits into from
Mar 20, 2024

Conversation

moshetanzer
Copy link
Contributor

@moshetanzer moshetanzer commented Mar 19, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I think that the example doesn't give clarity to basic user regarding middleware execution, have added 0 in from of the numbers, and an info message for clarities sake.

Here is a basic repro

https://stackblitz.com/edit/github-ph5sly?file=server%2Froutes%2Findex.ts

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

docs/1.guide/2.routing.md Outdated Show resolved Hide resolved
docs/1.guide/2.routing.md Outdated Show resolved Hide resolved
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pi0
Copy link
Member

pi0 commented Mar 20, 2024

Although having more than 10 middleware is strange...

@pi0 pi0 changed the title docs: middleware execution order docs: add note about middleware execution order Mar 20, 2024
@pi0 pi0 merged commit cb2d81d into nitrojs:main Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants