Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(options): set scheduledTasks to an empty object by default #2285

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

noook
Copy link
Contributor

@noook noook commented Mar 21, 2024

πŸ”— Linked issue

Fixes #2283, related to nuxt/devtools#626

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Nitro config types indicate that nitro.options.scheduledTasks should always be an object, empty or not. This PR makes the property an empty object as default as opposed to undefined which is not assignable to

scheduledTasks: { [cron: string]: string | string[] }

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

src/nitro.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title fix: make scheduledTasks nitro config match options types fix(options): set scheduledTasks to an empty object by default Mar 21, 2024
@pi0 pi0 merged commit d12aae1 into nitrojs:main Mar 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled tasks type on nitro options are incorrect
2 participants