Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): return T from Serialize when it extends undefined #2286

Merged
merged 7 commits into from
Mar 21, 2024
Merged

fix(types): return T from Serialize when it extends undefined #2286

merged 7 commits into from
Mar 21, 2024

Conversation

DamianGlowala
Copy link
Contributor

@DamianGlowala DamianGlowala commented Mar 21, 2024

πŸ”— Linked issue

resolves #1762
resolves nuxt/nuxt#26411

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently, Serialize<undefined> resolves to never (matching T extends NonJsonPrimitive). This PR returns T from Serialize when it extends undefined.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: return T from Serialize when it extends undefined fix(types): return T from Serialize when it extends undefined Mar 21, 2024
@pi0 pi0 merged commit a077cb2 into nitrojs:main Mar 21, 2024
4 checks passed
@pi0
Copy link
Member

pi0 commented Mar 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants