Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(openapi): upgrade to openapi 3.1 #2297

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

hanspagel
Copy link
Contributor

@hanspagel hanspagel commented Mar 22, 2024

πŸ”— Linked issue

–

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  1. The OpenAPI file we’re generating is set to be OpenAPI 3.0, which is fine. But we can safely make it 3.1, as this just has additions to the 3.0 specification. In other words: What works in 3.0, works in 3.1, too.

  2. I’ve also removed the URL description from the OpenAPI file. Currently, the OpenAPI stuff is only rendered in local development, but we’d probably want to enable a production-use of it, too and the request URL is already dynamic.

  3. The schemes property came from Swagger 2.0 and we can safely remove it here.

Looking forward to get your feedback!

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented Mar 22, 2024

I’ve also removed the URL description from the OpenAPI file. Currently, the OpenAPI stuff is only rendered in local development, but we’d probably want to enable a production-use of it, too and the request URL is already dynamic.

sure but today, it is experimental and local only. what's the point of removing it?

@pi0 pi0 changed the title chore: upgrade from OpenAPI 3.0 to OpenAPI 3.1 refactor(openapi): upgrade to openapi 3.1 Mar 22, 2024
@hanspagel
Copy link
Contributor Author

Now that you’re asking, there’s probably no good reason. Sorry. :) I’ve added it again.

@pi0 pi0 merged commit d1b9291 into nitrojs:main Mar 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants