fix: remove base url before calculating route rules #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Dec 19, 2022
| @@ -32,7 +33,7 @@ export function getRouteRules(event: H3Event): NitroRouteRules { | |||
| event.context._nitro = event.context._nitro || {}; | |||
| if (!event.context._nitro.routeRules) { | |||
| const path = new URL(event.req.url, "http://localhost").pathname; | |||
| event.context._nitro.routeRules = getRouteRulesForPath(path); | |||
| event.context._nitro.routeRules = getRouteRulesForPath(withoutBase(path, useRuntimeConfig().app.baseURL)); | |||
There was a problem hiding this comment.
I'm wondering if we should do this directly inside getRouteRulesForPath?
There was a problem hiding this comment.
I felt it was more natural here as we have access to event; getRouteRulesForPath feels like more of a 'pure' function. Also, looking at usage, it is used with an already normalised url, meaning if we move this there we are likely to double-remove a baseURL:
pi0
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
nuxt/nuxt#15610
❓ Type of change
📚 Description
This PR removes baseURL before calculating route rules.
📝 Checklist