Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(deployment): heroku with nginx #873

Merged
merged 1 commit into from
Jan 25, 2023
Merged

docs(deployment): heroku with nginx #873

merged 1 commit into from
Jan 25, 2023

Conversation

adetayoadeyemi
Copy link
Contributor

…nx buildpack, a Nitro plugin and the node preset

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The update documents setting up nginx on heroku
With this change, setting up nuxt on heroku with Nginx is straight forward, the update also explains how to use Nginx to server static files, this is a question that has been repeated a number of times on the Discord channel

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@adeyemiadetayoccl
Doc Update:steps for setting up Heroku and Nginx using the Heroku Ngi…
b99b11c 
…nx buildpack, a Nitro plugin and the node preset
@pi0 pi0 mentioned this pull request Jan 25, 2023
Closed
pi0
pi0 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've made a followup issue to possibly make a dedicated preset too if we can #876

@pi0 pi0 changed the title docs: steps for setting up Heroku and Nginx using the Heroku Ngi… docs(deployment): heroku with nginx Jan 25, 2023
@pi0 pi0 merged commit 61f0c7b into nitrojs:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adetayoadeyemi @pi0 @adeyemiadetayoccl