Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(externals): use portable symlinks #882

Merged
merged 1 commit into from
Jan 25, 2023
Merged

fix(externals): use portable symlinks #882

merged 1 commit into from
Jan 25, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jan 25, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #882 (bfb95b3) into main (2c52c62) will decrease coverage by 0.05%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   67.42%   67.38%   -0.05%     
==========================================
  Files          59       59              
  Lines        5852     5860       +8     
  Branches      633      634       +1     
==========================================
+ Hits         3946     3949       +3     
- Misses       1897     1901       +4     
- Partials        9       10       +1     
Impacted Files Coverage Ξ”
src/rollup/plugins/externals.ts 95.11% <92.30%> (+0.07%) ⬆️
src/rollup/config.ts 91.66% <0.00%> (-0.93%) ⬇️
src/utils/index.ts 52.35% <0.00%> (-0.53%) ⬇️
src/scan.ts 72.72% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 6596c5f into main Jan 25, 2023
@pi0 pi0 deleted the fix/portable-link branch January 25, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant