Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use json response for errors in /api/ routes #971

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: use json response for errors in /api/ routes #971

merged 1 commit into from
Feb 21, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 21, 2023

πŸ”— Linked issue

resolves #951

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

To avoid breaking changes, this PR uses json response again for routes starting with /api

PS: This is temporary. We might find better solutions to show pretty error pages for API later. Also notes in #951 (comment)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: use json response for /api/ routes again fix: use json response for /api/ routes Feb 21, 2023
@pi0 pi0 changed the title fix: use json response for /api/ routes fix: use json response for errors in /api/ routes Feb 21, 2023
@pi0 pi0 merged commit f9d739a into main Feb 21, 2023
@pi0 pi0 deleted the fix/api-json branch February 21, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant