Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for sourceMap values: hidden, inline #998

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

alex-key
Copy link
Contributor

@alex-key alex-key commented Feb 26, 2023

πŸ”— Linked issue

nuxt/nuxt#19253

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds support of more values for sourceMap config option. Now additionally inline and hidden are available in accordance with Rollup: https://rollupjs.org/configuration-options/#output-sourcemap

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@nuxt-studio
Copy link
Contributor

nuxt-studio bot commented Feb 26, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview 098ad8f

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #998 (098ad8f) into main (d83f2b6) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
+ Coverage   67.79%   67.81%   +0.02%     
==========================================
  Files          60       60              
  Lines        6133     6134       +1     
  Branches      692      694       +2     
==========================================
+ Hits         4158     4160       +2     
+ Misses       1966     1965       -1     
  Partials        9        9              
Impacted Files Coverage Ξ”
src/rollup/plugins/esbuild.ts 54.41% <66.66%> (+1.07%) ⬆️
src/types/nitro.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit c63e504 into nitrojs:main Feb 28, 2023
@pi0
Copy link
Member

pi0 commented Feb 28, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants