Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use file url when building prerenderer #286

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#13801, resolves

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When prerendering, we don't want to use the source dist/server file, which still references virtual modules and other aliases. Instead, we want to inline it.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Jun 14, 2022
@danielroe danielroe requested a review from pi0 June 14, 2022 12:37
@danielroe danielroe self-assigned this Jun 14, 2022
@pi0 pi0 merged commit 2e7c548 into main Jun 14, 2022
@pi0 pi0 deleted the fix/windows-generate branch June 14, 2022 13:17
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package import specifier "#internal/nitro" is not defined in package when running npm run generate on windows
2 participants