Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-lambda): add multiValueQueryStringParameters to aws preset #398

Merged

Conversation

huang-julien
Copy link
Contributor

πŸ”— Linked issue

resolve #396

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR aims to add the multiValueQueryStringParameters from APIGatewayProxyEvent. Currently the request only retrieve the queries from the queryStringParameters, this don't allow us to have an array of query like /api?test=foo&test=bar&test=hello (this return only the last query -> { test: 'hello' }.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #398 (710fdbc) into main (801bc28) will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   55.96%   56.45%   +0.49%     
==========================================
  Files          54       54              
  Lines        3472     3431      -41     
  Branches      364      363       -1     
==========================================
- Hits         1943     1937       -6     
+ Misses       1178     1144      -34     
+ Partials      351      350       -1     
Impacted Files Coverage Ξ”
src/rollup/plugins/handlers.ts 61.90% <ΓΈ> (+22.61%) ⬆️
src/imports.ts 95.34% <0.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title fix(preset): add multiValueQueryStringParameters to aws preset fix(aws-lamda): add multiValueQueryStringParameters to aws preset Aug 24, 2022
@pi0 pi0 changed the title fix(aws-lamda): add multiValueQueryStringParameters to aws preset fix(aws-lamda): add multiValueQueryStringParameters to aws preset Aug 24, 2022
@pi0 pi0 changed the title fix(aws-lamda): add multiValueQueryStringParameters to aws preset fix(aws-lambda): add multiValueQueryStringParameters to aws preset Aug 24, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pi0 pi0 merged commit 5356f62 into nitrojs:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aws lambda preset miss the multiValueQueryStringParameters object
2 participants