feat: improve public asset compression #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Sep 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #466 +/- ##
==========================================
- Coverage 63.43% 63.26% -0.17%
==========================================
Files 54 54
Lines 3569 3607 +38
Branches 378 382 +4
==========================================
+ Hits 2264 2282 +18
- Misses 1294 1314 +20
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pi0
changed the title
WinterYukky
pushed a commit
to WinterYukky/nitro
that referenced
this pull request
Nov 1, 2022
* Improve compressPublicAssets * Change sync to async compression * small refactors * refactor callback handling Co-authored-by: Pooya Parsa <pooya@pi0.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This PR allows specifying the compression algorithm in the
compressPublicAssetsoption.All public assets are no longer compressed, but only selected types are. Since some file types are already internally compressed and double compression is just a waste of time and energy.
The compression level has also been set to maximum quality, which makes compressed files smaller in size and therefore faster to download.
π Checklist