Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node-resolve's modulePaths #490

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix: use node-resolve's modulePaths #490

merged 1 commit into from
Sep 12, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#14883

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

regression from #489
see https://github.com/rollup/plugins/blob/master/packages/node-resolve/CHANGELOG.md#v1410

There's been a config schema change in @rollup/node-resolve. This PR passes resolved directories to the correct location. moduleDirectories defaults to ['node_modules'] so can be omitted.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 12, 2022
@danielroe danielroe requested a review from pi0 September 12, 2022 19:30
@danielroe danielroe self-assigned this Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #490 (76ddc5b) into main (6c09a94) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     nuxt/framework#490   +/-   ##
=======================================
  Coverage   63.29%   63.29%           
=======================================
  Files          54       54           
  Lines        3618     3618           
  Branches      380      380           
=======================================
  Hits         2290     2290           
  Misses       1316     1316           
  Partials       12       12           
Impacted Files Coverage Ξ”
src/rollup/config.ts 91.07% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit ef4fc58 into main Sep 12, 2022
@pi0 pi0 deleted the fix/module-paths branch September 12, 2022 20:05
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants