Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy support improvements #107

Closed
3 of 4 tasks
pi0 opened this issue Dec 23, 2023 · 3 comments
Closed
3 of 4 tasks

proxy support improvements #107

pi0 opened this issue Dec 23, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Dec 23, 2023

Docs

Nice article: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/

Tasks

@pi0 pi0 added the enhancement New feature or request label Dec 23, 2023
@pi0
Copy link
Member Author

pi0 commented Dec 23, 2023

/cc @TooTallNate I hope you find this attempt in a good direction. If you have any suggestions to improve it is more than welcome ❤️ (I plan to use this opt-in feature in couple of packages like giget and ofetch)

@CS-JJ
Copy link

CS-JJ commented Apr 15, 2024

the bypassProxy implementation doesn't check for port specification. Currently there is a workaround by just specifying the port in the no_proxy host declaration.

Can be checked using the following

if (_host === host.split(":").at(0) || (_host[0] === "." && host.endsWith(_host.slice(1)))) {

Or if you want to save CPU cycles just over write the host parameter

host = host.split(':').at(0);

@pi0 pi0 closed this as completed Apr 16, 2024
@pi0
Copy link
Member Author

pi0 commented Apr 16, 2024

@CS-JJ Would you please make a new issue with proper reproduction? 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants