Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve windows path handling and improve coverage #36

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe added the bug Something isn't working label Aug 8, 2022
@danielroe danielroe requested a review from pi0 August 8, 2022 16:16
@danielroe danielroe self-assigned this Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #36 (0908228) into main (7a35075) will increase coverage by 3.52%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   60.00%   63.52%   +3.52%     
==========================================
  Files           3        3              
  Lines         240      244       +4     
  Branches       81       89       +8     
==========================================
+ Hits          144      155      +11     
+ Misses         18        0      -18     
- Partials       78       89      +11     
Impacted Files Coverage Δ
src/utils.ts 42.85% <0.00%> (ø)
src/path.ts 63.98% <46.66%> (+3.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 merged commit 34a55cf into main Aug 10, 2022
@pi0 pi0 deleted the fix/windows-joy branch August 10, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants