Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-info update #4

Closed
aslafy-z opened this issue Jul 8, 2020 · 6 comments
Closed

ci-info update #4

aslafy-z opened this issue Jul 8, 2020 · 6 comments

Comments

@aslafy-z
Copy link

aslafy-z commented Jul 8, 2020

After digging a bit, I found out that the plugin you use to detect CI, does not support GitHub action with the pinned version. There was no release (watson/ci-info#48) since support was implemented (watson/ci-info#42). Consider pinning a commit, or forking the project.

Copy link
Member

atinux commented Jan 15, 2021

Thank you @aslafy-z, we will discuss with @pi0 about the best approach for this.

@pi0 pi0 changed the title Add support for Github Action github action detection (ci-info pending) Jan 15, 2021
@pi0
Copy link
Member

pi0 commented Jan 15, 2021

Since ci-info is widely used, it is more preferred waiting for update instead of forking. Seems @sibiraj-s started working ~4 days ago ❤️ so giving more time for release

@atinux
Copy link
Member

atinux commented Jan 15, 2021

Side note, it seems that GitHub actions now set CI=true since April 2020: https://github.blog/changelog/2020-04-15-github-actions-sets-the-ci-environment-variable-to-true/

@atinux atinux added the pending label Jan 15, 2021
@pi0 pi0 changed the title github action detection (ci-info pending) ci-info update Jan 15, 2021
@sibiraj-s
Copy link

sibiraj-s commented Jan 16, 2021

Hi, I am a maintainer of the project ci-info but do not have publish permissions. I have raised a dispute to npm, the issue should be resolved shortly.

That said.

Detecting CI on Github Actions should work without latest version as it sets CI=true as mentioned by @atinux . In case if other changes in master is required, temporarily you can pin it to the latest commit for now.

@sibiraj-s
Copy link

Published a new version v3.0.0 just now.

@pi0
Copy link
Member

pi0 commented Feb 17, 2021

Thanks! Landed by 2.3.0

@pi0 pi0 closed this as completed Feb 17, 2021
@pi0 pi0 removed the pending label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants