Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package subpath exports/imports to external by default #351

Closed
pi0 opened this issue Dec 24, 2023 · 1 comment · Fixed by #469
Closed

Add package subpath exports/imports to external by default #351

pi0 opened this issue Dec 24, 2023 · 1 comment · Fixed by #469
Labels
enhancement New feature or request

Comments

@pi0
Copy link
Member

pi0 commented Dec 24, 2023

(also #467)

Would be worth to add package name (and subpaths) to externals by default

@pi0 pi0 added the enhancement New feature or request label Jun 4, 2024
@pi0 pi0 changed the title Add package name to externals by default Add package subpath exports to external by default Dec 27, 2024
@olets
Copy link

olets commented Dec 27, 2024

pi0 I know you already know this, but repeating here in case it helps others untangle the linked issues:

This would resolve the bug of subpath imports triggering an external imports warning reproduced in https://stackblitz.com/edit/unbuild-301-subpath-import-false-positive-warning

@pi0 pi0 changed the title Add package subpath exports to external by default Add package subpath exports/imports to external by default Dec 27, 2024
@pi0 pi0 closed this as completed in #469 Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants