Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return this when calling setHeader, end and destroy #20

Merged
merged 2 commits into from
Dec 1, 2021
Merged

fix: return this when calling setHeader, end and destroy #20

merged 2 commits into from
Dec 1, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe requested a review from pi0 November 19, 2021 16:01
@danielroe danielroe self-assigned this Nov 19, 2021
@danielroe danielroe changed the title fix: return request after setting header fix: return response after setting header Nov 19, 2021
@pi0
Copy link
Member

pi0 commented Nov 19, 2021

Nice find. Cheking code, it seems we also need to allow chaining for end and destryo (in wriable base) do you mind to also fix these two?

@danielroe
Copy link
Member Author

For those, we'll need to wait on DefinitelyTyped/DefinitelyTyped#57473.

@pi0
Copy link
Member

pi0 commented Dec 1, 2021

@danielroe Can we maybe ignore return type (return this but type as void) until types are fixed?

@danielroe
fix: return this as void 😈
edd4205 
* pending upstream PR
@pi0 pi0 changed the title fix: return response after setting header fix: return this when calling setHeader, end and destroy Dec 1, 2021
@pi0 pi0 merged commit 4ac95fd into main Dec 1, 2021
@pi0 pi0 deleted the fix/set-header branch December 1, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 Awaiting requested review from pi0 pi0 is a code owner

Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0