Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust webpack rspack hooks sequence #326

Merged
merged 4 commits into from
Sep 17, 2023

Conversation

qiYuei
Copy link
Contributor

@qiYuei qiYuei commented Aug 1, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

webpack | Rspack, The load hook should be executed earlier than the transform hook

I'm not sure if I'm doing this as a Breaking change

image

minimal reproduction

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@antfu antfu changed the title Adjust webpack rspack hooks sequence fix: adjust webpack rspack hooks sequence Aug 1, 2023
@antfu
Copy link
Member

antfu commented Aug 1, 2023

It seems to make sense. Possible to add some tests to it?

@qiYuei
Copy link
Contributor Author

qiYuei commented Aug 1, 2023

okay,I try to write it.But there seems to be something wrong with the rspack in my environmentπŸ˜….I'll fill in the Rspack test cases later

@qiYuei
Copy link
Contributor Author

qiYuei commented Aug 4, 2023

@antfu hello,I have submitted the test files, please check it!😁

@qiYuei
Copy link
Contributor Author

qiYuei commented Aug 14, 2023

@antfu Can this be merged? Or what else do I need to change 🧐

@easonsolov
Copy link

hi,I have been using unplugin recently and have encountered the same issue with a plugin. Is there any progress with this PR? Or is this a bug that belongs to unplugin? thanks @antfu @sxzz

@antfu antfu merged commit 63e027a into unjs:main Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants