Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure drivers don't modify input options object #566

Open
1 task done
pi0 opened this issue Jan 7, 2025 · 0 comments
Open
1 task done

Make sure drivers don't modify input options object #566

pi0 opened this issue Jan 7, 2025 · 0 comments
Labels
bug Something isn't working test

Comments

@pi0
Copy link
Member

pi0 commented Jan 7, 2025 •
edited
Loading

Describe the feature

Found from nitrojs/nitro#2174

Drivers such as fs/fsLite currently modify options objects. this might have unwanted side-effects especially if input options are used in different places.

We should:

  • Make defineDriver types to make sure options object is (deep) ReadOnly
  • Possibly update tests to make sure there is no runtime update
  • Fix drivers that currently modify input to instead, make a copy of object

Additional information

  • Would you be willing to help implement this feature?
@pi0 pi0 added bug Something isn't working test labels Jan 7, 2025
@pi0 pi0 mentioned this issue Jan 7, 2025
Merged
@pi0 pi0 changed the title Make sure drivers don't upsdate input options object Make sure drivers don't modify input options object Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pi0