Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🕹️] Dashboard icon flickering #2156

Closed
3 tasks done
Flo4604 opened this issue Oct 2, 2024 · 12 comments · Fixed by #2170
Closed
3 tasks done

[🕹️] Dashboard icon flickering #2156

Flo4604 opened this issue Oct 2, 2024 · 12 comments · Fixed by #2170
Assignees

Comments

@Flo4604
Copy link
Contributor

Flo4604 commented Oct 2, 2024

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

Whenever I switch tabs In the workspace, the icon of the tab I select flickers
See video: https://github.com/user-attachments/assets/fe55dca6-a734-43e5-b74b-fc917a8edd40

Steps to Reproduce

Click around in the workspace tabs

Expected behavior

I except the icons to be smoothly changed/animated

Other information

No response

Screenshots

No response

Version info

- OS: macos 15.1 Beta (24B5055e)
- Browser: Arc Version 1.63.0 (54317)-RC
  - Chromium Engine Version 129.0.6668.71
@Flo4604 Flo4604 added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 2, 2024
Copy link

linear bot commented Oct 2, 2024

@chronark chronark changed the title Dashboard icon flickering [🕹️] Dashboard icon flickering Oct 3, 2024
@chronark
Copy link
Collaborator

chronark commented Oct 3, 2024

This is caused by out transition when the navigation is cached and therefore nearly instant.

Maybe we can add a delay to the animation when transitioning. And only if it takes more than 50ms, then we start displaying the loading indicator

@tcchawla
Copy link

tcchawla commented Oct 3, 2024

Hey everyone, I'm new to Unkey. Looks amazing to me, would like to learn more. Can I pick up this issue?

@Flo4604
Copy link
Contributor Author

Flo4604 commented Oct 3, 2024

Hey everyone, I'm new to Unkey. Looks amazing to me, would like to learn more. Can I pick up this issue?

yeah you can use /assign and participate in the oss.gg hackathon with that too

@chronark
Copy link
Collaborator

chronark commented Oct 3, 2024

what flo said
also here's a bit more context as well :)
https://app.campsite.com/unkey/p/notes/unkey-hacktoberfest-side-quests-challenges-lexof2nmtljf

@chronark
Copy link
Collaborator

chronark commented Oct 3, 2024

/award 150 points

Copy link

oss-gg bot commented Oct 3, 2024

Awarding Flo4604: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Flo4604

@AkshayBandi027
Copy link
Contributor

/assign

Copy link

oss-gg bot commented Oct 3, 2024

Assigned to @AkshayBandi027! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Copy link

oss-gg bot commented Oct 5, 2024

@AkshayBandi027, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

2 similar comments
Copy link

oss-gg bot commented Oct 7, 2024

@AkshayBandi027, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 9, 2024

@AkshayBandi027, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants