Lot of mutateAsync functions not being awaited

[harshsbhat]

Preliminary Checks

• I have reviewed the documentation: https://unkey.com/docs

• I have searched for existing issues: https://github.com/unkeyed/unkey/issues

• This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

It is usually a good practice to await the mutation async functions. We are missing that in a lot of instances. I have just listed one of them. There are at least a few more of these being used without awaiting

  async function onSubmit(values: z.infer<typeof formSchema>) {
    updateRatelimit.mutateAsync(values);
  }

Steps to Reproduce

NA

Expected behavior

We should await these functions.

Other information

No response

Screenshots

No response

Version info

- OS:
- Node:
- npm:

[linear]

ENG-1375 Lot of mutateAsync functions not being awaited

[chronark]

/award 150 points

[oss-gg]

Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat

[NeerajReddyK]

Can I get that assigned? (if it is up for grabs)

[NeerajReddyK]

/assign

[oss-gg]

Assigned to @NeerajReddyK! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[harshsbhat]

/assign

I was testing it and was done with it. If you have started working I can discard the changes. But if you haven't can you stop?

[NeerajReddyK]

Sure. I request you to proceed

[DeepaPrasanna]

/assign

I was testing it and was done with it. If you have started working I can discard the changes. But if you haven't can you stop?

Hey, @chronark will I be wrong in saying that one should start working on an issue only after being assigned, so that others wont have any misunderstanding. I have seen in other oss.gg repos that you cant work on more than 1 issue in the same repo at the same time. You can move to another issue only after your previous issue has been merged/closed so that this gives everyone a fair chance. Apologies if I misunderstood/or spoke wrong 🙏

[harshsbhat]

/assign

I was testing it and was done with it. If you have started working I can discard the changes. But if you haven't can you stop?

Hey, @chronark will I be wrong in saying that one should start working on an issue only after being assigned, so that others wont have any misunderstanding. I have seen in other oss.gg repos that you cant work on more than 1 issue in the same repo at the same time. You can move to another issue only after your previous issue has been merged/closed so that this gives everyone a fair chance. Apologies if I misunderstood/or spoke wrong 🙏

The thing is my other PR ( which I was assigned is already approved and tests are running ) that's why I asked him. Hope that was fair. I apologies if it was fair.

[DeepaPrasanna]

I think you should wait for your PR to be closed/merged. You can try /assign here. I believe it wont work when you have open PRs

[chronark]

Hmm, yeah we should try to distribute issues a bit better, so newcomers have a chance to grab some too.
The "only one active PR" rule is a bit too strict sometimes, cause that means you're potentially blocked on my review.

[DeepaPrasanna]

Yes, I do agree. Yesterday, I had to wait until my PR got merged to assign myself another(I understand It is not easy you guys do reviews and work on new features at the same time. I am grateful for all the reviews that I recieve.) but I believe we can use that time to explore other repos or try non code contributions.

[harshsbhat]

should I open the PR for this one or not then?

@chronark @DeepaPrasanna I think having a tag like first-timers only like freecodecamp can help us give new comers a good and fair chance on the simpler issues wdyt?

[chronark]

let's leave it open for someone else to come in
if nobody takes it within the next 24h, go ahead

[geraldmaboshe]

/assign

[oss-gg]

Assigned to @geraldmaboshe! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[harshsbhat]

@geraldmaboshe feel free to refer my closed PR

[geraldmaboshe]

cool, thanks for the cheatsheet @harshsbhat 😃

[oss-gg]

@NeerajReddyK, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[anand1564]

/assign

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[harshsbhat]

@anand1564 there is already a PR open for this issue

[oss-gg]

@NeerajReddyK, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.