Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear definition for baseUrl in the docs #2210

Closed
3 tasks done
DeepaPrasanna opened this issue Oct 5, 2024 · 11 comments · Fixed by #2223
Closed
3 tasks done

Unclear definition for baseUrl in the docs #2210

DeepaPrasanna opened this issue Oct 5, 2024 · 11 comments · Fixed by #2223
Assignees
Labels

Comments

@DeepaPrasanna
Copy link
Contributor

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

Noticed an unclear description for the baseUrl

The age of the user. Cannot be less than 0

test2

Steps to Reproduce

  1. Here

Expected behavior

Maybe there should be the definition for the baseUrl or no description as the baseUrl itself is descriptive.

Other information

No response

Screenshots

No response

Version info

- OS:
- Node:
- npm:
@DeepaPrasanna DeepaPrasanna added Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 5, 2024
Copy link

linear bot commented Oct 5, 2024

@DeepaPrasanna
Copy link
Contributor Author

Sorry , this is a docs issue, not a bug

@chronark
Copy link
Collaborator

chronark commented Oct 5, 2024

Huh, super weird, I wonder how that happened
there's also a typo in the sentence above

@chronark chronark added Documentation Improvements or additions to documentation 🕹️ oss.gg 🕹️ 150 points hacktoberfest and removed Bug Something isn't working Needs Approval Needs approval from Unkey labels Oct 5, 2024
@chronark
Copy link
Collaborator

chronark commented Oct 5, 2024

/award 150

Copy link

oss-gg bot commented Oct 5, 2024

Awarding DeepaPrasanna: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/DeepaPrasanna

@DeepaPrasanna
Copy link
Contributor Author

Huh, super weird, I wonder how that happened there's also a typo in the sentence above

ah yes! There's a typo too. What sentence you want to show in the description or shall I remove that sentence? BaseUrl is pretty descriptive

@DeepaPrasanna
Copy link
Contributor Author

/assign

Copy link

oss-gg bot commented Oct 5, 2024

Assigned to @DeepaPrasanna! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@chronark
Copy link
Collaborator

chronark commented Oct 5, 2024

yeah, the sentence above (after fixing the typo) is description enough, just remove the weird sentence

Copy link

oss-gg bot commented Oct 7, 2024

@DeepaPrasanna, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

1 similar comment
Copy link

oss-gg bot commented Oct 9, 2024

@DeepaPrasanna, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants