Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Unable to add certain permissions to key without changing the role #2870

Open
3 tasks done
Flo4604 opened this issue Feb 4, 2025 · 4 comments
Open
3 tasks done
Labels
Bug Something isn't working Core Team

Comments

@Flo4604
Copy link
Contributor

Flo4604 commented Feb 4, 2025

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

Currently, the key details page has no way of just assigning permission to a key.

It currently lists all roles and the permissions of those roles, any changes done there will affect the whole role and not only the key.

Clipboard-20250204-223253-627.mp4

Steps to Reproduce

Expected behavior

I would expect to be able to add roles to the key and permissions separately.

This could be done by showing all roles and having a checkbox for which roles should be attached to the key.
Then, another menu could list all permissions currently linked to the key, either due to a linked role having this permission or the permission being directly attached to the key.

Other information

No response

Screenshots

No response

Version info

-
@Flo4604 Flo4604 added Bug Something isn't working Needs Approval Needs approval from Unkey labels Feb 4, 2025
Copy link

linear bot commented Feb 4, 2025

@chronark chronark removed the Needs Approval Needs approval from Unkey label Feb 5, 2025
@Nelwhix
Copy link
Contributor

Nelwhix commented Feb 6, 2025

@chronark I would like to work on this. What will be the ideal flow? I am thinking the permissions section will still list out the roles and permissions but if you check directly on a permission. It attaches just that permission instead of the whole role to the key. Is that okay?

@chronark
Copy link
Collaborator

I'd hold off on this, as any fix will be shortlived before we redesign this page in march

@Nelwhix
Copy link
Contributor

Nelwhix commented Feb 10, 2025

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Team
Projects
None yet
Development

No branches or pull requests

4 participants